Fix docs and test #171
Merged
Fix docs and test #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 15 15
Lines 1425 1425
=======================================
Hits 1379 1379
Misses 46 46 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
daniel-dodd
reviewed
Jan 4, 2023
|
@daniel-dodd I'm going to move the docs building back to a Github workflow for now. |
daniel-dodd
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs within the documentation. The bugs are all hangovers from the recent update to Jax v0.4.
The PR also includes a testing job to our CircleCI workflow to ensure that all notebooks compile before using them to build the documentation site.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The docs do not currently build. Worse still, we will not know this as they are not being tested.
Issue Number: #169 #170